new lint: pub_api_sealed_trait_became_unconditionally_sealed
#1166
Conversation
lovelindhoni
changed the title
pub_api_sealed_trait_became_unconditionally_sealed
| error_message: "A public API sealed trait is now unconditionally sealed, preventing all external implementations. | ||
| This change impacts related first-party crates (e.g., derive macros or other internal tooling) | ||
| that previously could implement the trait using non-public API", |
There was a problem hiding this comment.
I don't believe this will get formatted correctly with our RON format. I think it'll end up stored and read as a multi-line string with the exact set of newline and consecutive space characters as exist in this file.
You can verify this by running cargo run -- semver-checks --manifest-path test_crates/pub_api_sealed_trait_became_unconditionally_sealed/new/Cargo.toml --baseline-root test_crates/pub_api_sealed_trait_became_unconditionally_sealed/old/Cargo.toml and seeing whether the error message is printed correctly. I suspect it'll come out hard-wrapped in an unpredictable and undesirable way.
There was a problem hiding this comment.
Indeed, the output is rather abnormal. I rewritten that to match other queries
| importable_path { | ||
| path @filter(op: "=", value: ["%path"]) | ||
| public_api @filter(op: "=", value: ["$true"]) | ||
| } | ||
| span_: span @optional { | ||
| filename @output | ||
| begin_line @output | ||
| end_line @output | ||
| } |
There was a problem hiding this comment.
nit: Please take a look at some of the other lints' queries and try to match the style and formatting of queries. The fact that this query is so dense and has no whitespace means it's quite difficult to read.
| This change prevents all external implementations, including from related first-party crates | ||
| that might have relied on private API access", | ||
| required_update: Major, | ||
| lint_level: Deny, |
There was a problem hiding this comment.
Is this the right lint level here?
src/lints/pub_api_sealed_trait_became_unconditionally_sealed.ron
Outdated
Show resolved
Hide resolved
src/lints/pub_api_sealed_trait_became_unconditionally_sealed.ron
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
src/lints/pub_api_sealed_trait_became_unconditionally_sealed.ron
Outdated
Show resolved
Hide resolved
src/lints/pub_api_sealed_trait_became_unconditionally_sealed.ron
Outdated
Show resolved
Hide resolved
lovelindhoni
deleted the
pub-api-sealed-trait-became-unconditionally-sealed
branch
Resolves #1122